Repository navigation
!remove(react-native): Old SDK versions support - #984
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #984 +/- ##
==========================================
+ Coverage 27.55% 27.72% +0.17%
==========================================
Files 129 129
Lines 14096 13854 -242
Branches 835 831 -4
==========================================
- Hits 3884 3841 -43
+ Misses 10194 9995 -199
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b9fd99f to
77f549c
Compare
ba032e4 to
6265bba
Compare
77f549c to
04d1565
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR removes support for old SDK versions by eliminating CLI-based patching in favor of bundled scripts and updates the supported SDK version range.
- Removed tests and functions related to CLI-based patching in the Xcode integration.
- Updated the SDK support range in the React Native wizard and removed associated fallback logic.
- Removed the Metro serializer patch function in favor of a simplified configuration.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/react-native/xcode.test.ts | Removed tests for the deprecated CLI-based patch functionality. |
| src/react-native/xcode.ts | Removed functions for CLI-based patching and fallback behavior. |
| src/react-native/react-native-wizard.ts | Updated SDK range and simplified session replay/feedback logic. |
| src/react-native/metro.ts | Removed the legacy Metro serializer patching function. |
| CHANGELOG.md | Updated changelog to reflect removal of old SDK support. |
|
Angular Job fail is unrelated to this PR, likely related to the momental Sentry unavailability. |
There was a problem hiding this comment.
LGTM 🚀
The wizard is ment to setup new projects, new project should use the latest version.
This makes a lot of sense ➕
Angular Job fail is unrelated to this PR, likely related to the momental Sentry unavailability.
Indeed! Rerunning the checks today worked 👍
Lms24
left a comment
There was a problem hiding this comment.
Same ask asks as in #983 (review) but LGTM!
6265bba to
11d2f80
Compare
1c4ecfa to
3248739
Compare
39457a7 to
0be8d2d
Compare
The React Native wizard supports multiple Sentry RN SDKs versions (v5 v6) and we are currently working on a new major version v7 and related to that this PR cleans up the old versions support.
The wizard is ment to setup new projects, new project should use the latest version. We don't intentionally break compatibility with older SDK version, but as you can see in this PR, the support of older versions required a lot of extra logic.
New supported version is RN SDK 6.12.0+
This is a breaking change.