Skip to content

fix(remix): linting issues in generated client init code - #949

Merged
constantinius merged 6 commits into
masterfrom
constantinius/fix/remix/linting-errors
Apr 16, 2025
Merged

constantinius merged 6 commits into
masterfrom
constantinius/fix/remix/linting-errors

Conversation

@constantinius

Copy link
Copy Markdown
Contributor

@constantinius
constantinius requested a review from a team April 15, 2025 09:45
@codecov

codecov Bot commented Apr 15, 2025 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.28%. Comparing base (c29b8ee) to head (ba618ea).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #949      +/-   ##
==========================================
+ Coverage   24.24%   24.28%   +0.03%     
==========================================
  Files         121      121              
  Lines       12877    12883       +6     
  Branches      713      715       +2     
==========================================
+ Hits         3122     3128       +6     
  Misses       9734     9734              
  Partials       21       21              
Flag Coverage Δ
unit-tests 24.28% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@constantinius
constantinius requested a review from s1gr1d April 16, 2025 07:56
Comment thread e2e-tests/tests/remix.test.ts Outdated
Comment thread test/remix/client-entry.test.ts Outdated
Comment thread test/remix/client-entry.test.ts Outdated
Comment thread test/remix/client-entry.test.ts Outdated
@constantinius
constantinius requested review from a team and s1gr1d and removed request for a team April 16, 2025 11:04
@lforst

lforst commented Apr 16, 2025

Copy link
Copy Markdown

I advise against this. This is due to an upstream issue, see import-js/eslint-plugin-import#2969

@lforst

lforst commented Apr 16, 2025

Copy link
Copy Markdown

Maybe it's fine idk

@s1gr1d s1gr1d left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for some additional info around this: There is a bug in the eslint import/namespace package and that's the reason why we even have those warnings here. #949

However, as users are confronted with this warning right after they install Sentry I think importing it directly (not via the namespace) is a good workaround.

@constantinius
constantinius merged commit 94bc714 into master Apr 16, 2025
@constantinius
constantinius deleted the constantinius/fix/remix/linting-errors branch April 16, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants