Repository navigation
feat(remix): New example page - #917
Merged
Merged
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #917 +/- ##
========================================
Coverage 51.79% 51.79%
========================================
Files 53 53
Lines 3657 3657
Branches 854 866 +12
========================================
Hits 1894 1894
+ Misses 1762 1633 -129
- Partials 1 130 +129
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ArthurKnaus
commented
Mar 27, 2025
Comment on lines
+116
to
+117
| {/* Not for production use! We're just saving you from having to delete an extra CSS file ;) */} | ||
| <style dangerouslySetInnerHTML={{ __html: styles }}></style> |
Member
Author
There was a problem hiding this comment.
Wanted to avoid creating an extra file.
Without dangerouslySetInnerHTML this runs into hydration errors as Remix tries to html-escape the content.
s1gr1d
approved these changes
Mar 27, 2025
Comment on lines
+116
to
+117
| {/* Not for production use! We're just saving you from having to delete an extra CSS file ;) */} | ||
| <style dangerouslySetInnerHTML={{ __html: styles }}></style> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redesign the example page & component for Nuxt.
Screen.Recording.2025-03-27.at.09.28.35.mov