Repository navigation
fix(react-native): Handle xcode build phase patching failure - #866
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #866 +/- ##
==========================================
+ Coverage 23.86% 24.24% +0.38%
==========================================
Files 121 121
Lines 12753 12817 +64
Branches 701 711 +10
==========================================
+ Hits 3043 3107 +64
Misses 9689 9689
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
antonis
marked this pull request as ready for review
March 18, 2025 18:14
# Conflicts: # CHANGELOG.md # src/react-native/xcode.ts
antonis
marked this pull request as draft
March 31, 2025 07:21
antonis
marked this pull request as ready for review
March 31, 2025 07:28
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
Contributor
|
I've noticed two small visual details; otherwise, it looks great! |
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
krystofwoldrich
approved these changes
Apr 14, 2025
krystofwoldrich
left a comment
Contributor
There was a problem hiding this comment.
LGTM 🚀 Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #572
Handled
Bundle React Native and imagesbuild phase patching gracefully and show a code snippet for manual configuration.