Repository navigation
feat: add coming-from parameter - #837
Merged
Merged
Conversation
obostjancic
commented
Mar 4, 2025
Member
- Part of https://github.com/getsentry/projects/issues/759
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #837 +/- ##
==========================================
- Coverage 51.15% 51.15% -0.01%
==========================================
Files 53 53
Lines 3517 3519 +2
Branches 825 827 +2
==========================================
+ Hits 1799 1800 +1
- Misses 1591 1718 +127
+ Partials 127 1 -126
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
obostjancic
marked this pull request as ready for review
March 5, 2025 09:29
lforst
approved these changes
Mar 5, 2025
lforst
left a comment
There was a problem hiding this comment.
Code-wise lgtm. However "partner" sounds extremely weird from a user-perspective as a CLI arg. I would name it something like --coming-from.
Lms24
approved these changes
Mar 5, 2025
Lms24
left a comment
Member
There was a problem hiding this comment.
Please also update the readme with the new arg, thx!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.