Repository navigation
fix: Remove bulk from npm - #825
Conversation
This patch removes further bulk from the npm package which became 183 MB due to `.node-cache` getting bundled in. This is a follow up to #820.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #825 +/- ##
========================================
Coverage 49.55% 49.55%
========================================
Files 52 52
Lines 3519 3519
Branches 826 826
========================================
Hits 1744 1744
+ Misses 1774 1639 -135
- Partials 1 136 +135
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@Lms24 would love to do that. Let me try. |
|
Did the following to test locally: yarn pack
cd ../
npm install sentry-wizard/sentry-wizard-v4.0.0.tgz
npx @sentry/wizard
|
Lms24
left a comment
There was a problem hiding this comment.
Just had one more question (see comment).
I think this will exclude a lot of files we previously published (see 3.4.0 as an example) but all of them are source files (+ not referenced from package.json) or stuff like the CHANGELOG which doesn't need to be included.
I also ran it locally and things seemed to work. Happy to 👍 once the comment is addressed
|
I also checked by running |
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
This patch removes further bulk from the npm package which became 183 MB due to
.node-cachegetting bundled in. This is a follow up to #820.