Skip to content

fix: Skip asking if users have sentry account if --org and --project flags were passed - #817

Merged
Lms24 merged 6 commits into
masterfrom
lms/fix-skip-already-sentry-account
Feb 26, 2025
Merged

Lms24 merged 6 commits into
masterfrom
lms/fix-skip-already-sentry-account

Conversation

@Lms24

@Lms24 Lms24 commented Feb 24, 2025 •

Copy link
Copy Markdown
Member

If users pass in --org and --project slugs, there's no need to ask them if they already created a sentry account, as they otherwise wouldn't even have any of this information.

closes #804

@codecov

codecov Bot commented Feb 24, 2025 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 65.62500% with 11 lines in your changes missing coverage. Please review.

Project coverage is 50.83%. Comparing base (69fa5fc) to head (a60814c).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/utils/clack-utils.ts 65.62% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #817      +/-   ##
==========================================
+ Coverage   49.74%   50.83%   +1.09%     
==========================================
  Files          53       53              
  Lines        3508     3517       +9     
  Branches      823      824       +1     
==========================================
+ Hits         1745     1788      +43     
+ Misses       1630     1601      -29     
+ Partials      133      128       -5     
Flag Coverage Δ
e2e-tests 80.85% <ø> (ø)
unit-tests 49.58% <65.62%> (+1.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lms24 Lms24 self-assigned this Feb 24, 2025
@Lms24
Lms24 requested review from lforst and smeubank February 24, 2025 15:54
@Lms24
Lms24 marked this pull request as ready for review February 24, 2025 15:55
@lforst

lforst commented Feb 25, 2025

Copy link
Copy Markdown

@codecov-ai-reviewer review

@ghost

ghost commented Feb 25, 2025

Copy link
Copy Markdown

On it! We are reviewing the PR and will provide feedback shortly.

@ghost

ghost commented Feb 25, 2025

Copy link
Copy Markdown

No changes requiring review at this time.

@Lms24
Lms24 merged commit 665abcf into master Feb 26, 2025
@Lms24
Lms24 deleted the lms/fix-skip-already-sentry-account branch February 26, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[wizard] skip asking if you have an account when providing saas, org, and project

2 participants