Repository navigation
fix: Refactor the wizard version lookup to handle gracefully - #816
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #816 +/- ##
==========================================
- Coverage 49.67% 49.61% -0.06%
==========================================
Files 52 52
Lines 3503 3507 +4
Branches 825 823 -2
==========================================
Hits 1740 1740
- Misses 1628 1631 +3
- Partials 135 136 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
philprime
marked this pull request as ready for review
February 24, 2025 15:26
BYK
requested changes
Feb 24, 2025
Co-authored-by: Burak Yigit Kaya <byk@sentry.io>
BYK
enabled auto-merge (squash)
February 24, 2025 21:02
BYK
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lookup of the
package.jsonof the@sentry/wizardcan throw when used during development outside of the repository. This is especially relevant developing the apple wizard, which is most likely in a project directory unrelated to the wizard.The current implementation will crash the wizard, rendering it unusable. Ideally we are hard-baking the version on
yarn build, but until then the dynamic lookup must not throw an error if the package.json is not found.It is better to have telemetry without a node version, instead of crashing the wizard.