Skip to content

fix: add fallback from parsing project package path candidates - #814

Merged
philprime merged 3 commits into
masterfrom
philprime/fixes
Feb 24, 2025
Merged

philprime merged 3 commits into
masterfrom
philprime/fixes

Conversation

@philprime

Copy link
Copy Markdown
Member

No description provided.

@philprime
philprime requested a review from BYK February 24, 2025 14:14
@codecov

codecov Bot commented Feb 24, 2025 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.67%. Comparing base (06385db) to head (6844342).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #814   +/-   ##
=======================================
  Coverage   49.67%   49.67%           
=======================================
  Files          52       52           
  Lines        3503     3503           
  Branches      814      825   +11     
=======================================
  Hits         1740     1740           
  Misses       1762     1762           
  Partials        1        1           
Flag Coverage Δ
e2e-tests 84.61% <ø> (ø)
unit-tests 48.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread lib/Steps/ChooseIntegration.ts Outdated
Comment thread lib/Steps/ChooseIntegration.ts Outdated

@BYK BYK left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀

Comment thread lib/Steps/ChooseIntegration.ts Outdated
Comment thread lib/Steps/ChooseIntegration.ts Outdated
@philprime
philprime requested a review from Lms24 February 24, 2025 15:19
@philprime

Copy link
Copy Markdown
Member Author

@Lms24 I pushed the changes as discussed, please test that the choose integration behavior is still working as expected.

@Lms24 Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! Tested it out and it doesn't crash/works as I'd expect it to.

@philprime
philprime merged commit c62ec74 into master Feb 24, 2025
@philprime
philprime deleted the philprime/fixes branch February 24, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants