Repository navigation
feat: Add self-contained binary artifacts - #806
Merged
Merged
Conversation
The added forced resolution for `simple-plist` is to fix bundling issues with this package that is solved in the latest version. Context: wollardj/simple-plist/issues#58 Fixes #758.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #806 +/- ##
==========================================
- Coverage 49.67% 49.61% -0.06%
==========================================
Files 52 52
Lines 3503 3515 +12
Branches 825 827 +2
==========================================
+ Hits 1740 1744 +4
- Misses 1628 1770 +142
+ Partials 135 1 -134
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BYK
marked this pull request as ready for review
February 21, 2025 16:39
Lms24
reviewed
Feb 24, 2025
Lms24
approved these changes
Feb 24, 2025
BYK
added a commit
that referenced
this pull request
Feb 24, 2025
Right now we pack the fossilized binaries to npm package on publish. This patch adds the `dist-bin` directory to `.npmignore` to make this impossible. Follow up to #806.
BYK
added a commit
that referenced
this pull request
Feb 25, 2025
* fix: Add dist-bin binaries dir to .npmignore Right now we pack the fossilized binaries to npm package on publish. This patch adds the `dist-bin` directory to `.npmignore` to make this impossible. Follow up to #806. * try level 6 compression again * back to level 3 compression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The added forced resolution for
simple-plistis to fix bundling issueswith this package that is solved in the latest version.
Context: wollardj/simple-plist#58
Fixes #758.