Skip to content

ref: Remove @sentry/cli as a dependency - #802

Merged
BYK merged 3 commits into
masterfrom
byk/ref/bye-sentry-cli
Feb 21, 2025
Merged

BYK merged 3 commits into
masterfrom
byk/ref/bye-sentry-cli

Conversation

@BYK

@BYK BYK commented Feb 21, 2025

Copy link
Copy Markdown
Member

We no longer require @sentry/cli to exist or to be installed so removing it.

We no longer require @sentry/cli to exist or to be installed so removing it.
@BYK
BYK requested a review from Lms24 February 21, 2025 10:58
@BYK
BYK enabled auto-merge (squash) February 21, 2025 10:58
@codecov

codecov Bot commented Feb 21, 2025 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.67%. Comparing base (668f183) to head (02c7718).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master     #802    +/-   ##
========================================
  Coverage   49.67%   49.67%            
========================================
  Files          52       52            
  Lines        3503     3503            
  Branches      825      814    -11     
========================================
  Hits         1740     1740            
- Misses       1628     1762   +134     
+ Partials      135        1   -134     
Flag Coverage Δ
e2e-tests 84.61% <ø> (ø)
unit-tests 48.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lms24 Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We somewhere print the Sentry CLI version when starting the wizard. I think we can get rid of this as well now that it's no longer a hard dependency.

Comment thread CHANGELOG.md Outdated
@BYK
BYK requested a review from Lms24 February 21, 2025 13:20

@Lms24 Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BYK
BYK merged commit 801fbe4 into master Feb 21, 2025
@BYK
BYK deleted the byk/ref/bye-sentry-cli branch February 21, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants