Repository navigation
feat: Add forceInstall option to NPM-based wizards - #791
Merged
Merged
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #791 +/- ##
==========================================
+ Coverage 49.47% 50.25% +0.77%
==========================================
Files 52 52
Lines 3527 3530 +3
Branches 894 896 +2
==========================================
+ Hits 1745 1774 +29
+ Misses 1596 1571 -25
+ Partials 186 185 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lforst
approved these changes
Feb 14, 2025
lforst
left a comment
There was a problem hiding this comment.
I thought about doing this by default but default but an option is a great escape hatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a CLI argument to make node package managers
--force-install a package when callinginstallPackage. This is of course only optional and defaults tofalse/undefined.Added this option to all SDK setup wizards using NPM. Didn't add it to the source maps wizard but we can do so at any time. If reviewers have objections to merging this, I'm also happy to close it in favour of not permitting force installs at all.
closes #788