Repository navigation
feat(flutter): Add Flutter support - #735
Conversation
# Conflicts: # CHANGELOG.md
|
@buenaflor Ready for the first review/feedback round :) |
buenaflor
left a comment
There was a problem hiding this comment.
I'll have another look later
Lms24
left a comment
There was a problem hiding this comment.
Hey, leaving a first pass review for general wizard recommendations. This is not technical as I have very little to no context around Flutter.
- Ideally, we can make the SDK features selectable from the start as we've done recently with the JS-SDK wizards. See #558
- Great to see some tests for this flow! :) I recommend adding an e2e test app as well as this proved quite useful for our other wizards.
Feel free to disregard my advice as I'll happily leave the final call to the mobile team. Don't want to block you, just share some recommendations :)
…o feat/flutter-support # Conflicts: # CHANGELOG.md
|
@krystofwoldrich could you take another looks pls 🙏 |
# Conflicts: # e2e-tests/utils/index.ts
# Conflicts: # CHANGELOG.md
|
@buenaflor Updated the description with the plugin PR, by which this PR is blocked. |
|
@denrase dart plugin 2.4.0 is out so this is unblocked |
|
We fetch the most recent version, so apart form another review round we should be god to go.
|
|
@denrase imo it looks good, there's some test failing though, dunno if it's flaky Seems like the tests are failing, I already re-ran them |
Just passing by since I saw this comment: If you rebase the PR to latest |
|
Hmm so @andreiborza and I looked into this and we have a slight suspicion what could cause it but honestly, nothing concrete. Given it worked in the latest run, let's ignore it for now 😅 Out of scope for this PR but leaving it here: If this comes up again or in other PRs, we should make our method of checking for a successful app start more robust. Either we make a request against the started endpoint or we use something like Playwright to check for a successful pageload/whatever. |
|
seems like tests run now, guess it was flaky? |
|
@denrase Thank you for adding the Flutter wizard, I've checked the latest changes and it looks good. I noticed one small typo #735 (comment) |
|
@krystofwoldrich done, thank you! 🙇 |
|
@Lms24 I'm noticing nuxt tests are timing out again, should we wait for a fix or are can we merge? I've re-ran a couple times but didn't succeed yet |
main.dartwith import, sentry setup and sample snippetpubspec.yamlwith sentry_flutter dependency and plugin to upload debug symbols and source mapsCloses getsentry/sentry-dart#2424
Relates to #558
We need to read both
pubspec.yamlandsentry.properties. The current plugin treats them as mutually exclusive. Fixed here:Blocked by getsentry/sentry-dart-plugin#295