Skip to content

feat(nuxt): Add import-in-the-middle install step when using pnpm - #727

Merged
andreiborza merged 4 commits into
masterfrom
ab/pnpm-install-iitm
Dec 6, 2024
Merged

andreiborza merged 4 commits into
masterfrom
ab/pnpm-install-iitm

Conversation

@andreiborza

@andreiborza andreiborza commented Dec 2, 2024 •

Copy link
Copy Markdown
Member

Waiting on: getsentry/sentry-docs#12002 to update the trouble shooting url.

Closes: #726

@andreiborza
andreiborza requested review from Lms24 and s1gr1d December 2, 2024 09:00
@andreiborza
andreiborza marked this pull request as draft December 2, 2024 09:00
@github-actions

github-actions Bot commented Dec 2, 2024 •

Copy link
Copy Markdown
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 5db6ce2

@andreiborza
andreiborza marked this pull request as ready for review December 6, 2024 09:12
Comment thread src/nuxt/sdk-setup.ts Outdated
}

if (PNPM.detect()) {
// For pnpm, we probably want to install iitm

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: probably? 😅

Suggested change
// For pnpm, we probably want to install iitm
// For pnpm, we probably want to install iitm

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably remove that :)

@andreiborza
andreiborza merged commit a81fe51 into master Dec 6, 2024
@andreiborza
andreiborza deleted the ab/pnpm-install-iitm branch December 6, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Install iitm when using pnpm

2 participants