Skip to content

Fix(Cordova) enhanced node path detection, debug symbols now run in foreground. - #694

Merged
krystofwoldrich merged 14 commits into
getsentry:masterfrom
lucas-zimerman:fix/cordova-node
May 19, 2025
Merged

krystofwoldrich merged 14 commits into
getsentry:masterfrom
lucas-zimerman:fix/cordova-node

Conversation

@lucas-zimerman

@lucas-zimerman lucas-zimerman commented Oct 22, 2024 •

Copy link
Copy Markdown
Contributor

This is a refactor on how the Cordova Integration runs, the main changes on the PR are:

  • More path options for sentry.properties.
  • Use node path from .xcode.env when node is not found.
  • Skip the integration if node isn't found, avoiding a build failure when running Sentry-CLI.
  • Use a more modern approach to find where Sentry-CLI is located.

@lucas-zimerman
lucas-zimerman marked this pull request as ready for review October 22, 2024 17:17
Comment thread lib/Steps/Integrations/Cordova.ts Outdated
Comment thread lib/Steps/Integrations/Cordova.ts Outdated
Comment thread lib/Steps/Integrations/Cordova.ts Outdated
@codecov

codecov Bot commented Feb 27, 2025 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 27.69%. Comparing base (0e3a41a) to head (9f5c01d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
lib/Steps/Integrations/Cordova.ts 0.00% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #694      +/-   ##
==========================================
- Coverage   27.72%   27.69%   -0.04%     
==========================================
  Files         129      129              
  Lines       13854    13871      +17     
  Branches      831      831              
==========================================
  Hits         3841     3841              
- Misses       9995    10012      +17     
  Partials       18       18              
Flag Coverage Δ
unit-tests 27.69% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread lib/Steps/Integrations/Cordova.ts Fixed
Comment thread lib/Steps/Integrations/Cordova.ts Outdated
Comment thread lib/Steps/Integrations/Cordova.ts
Comment thread lib/Steps/Integrations/Cordova.ts

@krystofwoldrich krystofwoldrich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@krystofwoldrich krystofwoldrich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@krystofwoldrich
krystofwoldrich merged commit 9dd8f6e into getsentry:master May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants