Repository navigation
fix(sveltekit): Ensure Sentry example page renders correct Html - #688
Merged
Merged
Conversation
Lms24
requested review from
a team,
AbhiPrasad and
mydea
and removed request for
a team
October 15, 2024 10:55
Lms24
force-pushed
the
lms/fix-sveltekit-example-page-html
branch
from
October 15, 2024 11:01
56cd80c to
9ba81c8
Compare
lforst
approved these changes
Oct 16, 2024
chargome
approved these changes
Oct 16, 2024
andreiborza
approved these changes
Oct 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SvelteKit in newer versions with the Svelte 5 preview enabled throws an error when a page includes a
<head>tag if the baseapp.htmltemplate also contains<head>(which it does by default). This PR therefore removes the<head>tag from our example page template and only leaves the<title>element top-level (which still works).Also removed the
<h1>around the<svg>b/c SvelteKit accessibility checker emitted a warning about it (h1 should always contain text)