Repository navigation
feat(flutter): Add structured logs opt-in - #1050
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1050 +/- ##
==========================================
- Coverage 28.76% 28.76% -0.01%
==========================================
Files 128 128
Lines 14581 14592 +11
Branches 945 946 +1
==========================================
+ Hits 4194 4197 +3
- Misses 10370 10378 +8
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Should it enabled by default or opt-in? |
|
@buenaflor It's not specified. Since logs are important, i assumed we'd want to add them by default. But then again, we could have just made the flag in the SDK true by default. Maybe @kahest can clarify? |
|
cc @AbhiPrasad should logs config in the wizard be auto-enabled? |
|
@denrase @buenaflor I added clarification around that to the issue |
|
Generally all wizard options should be opt-in, this is also what we do with the onboarding snippets |
| features.push({ | ||
| id: 'logs', | ||
| prompt: `Do you want to enable ${chalk.bold( | ||
| 'Logs', | ||
| )} to send your application logs to Sentry?`, | ||
| enabledHint: 'optional', | ||
| }); |
There was a problem hiding this comment.
okay we are aligned but actually I don't know if this is accurate since we don't ootb instrument user logs with sentry logs (dont even know if that is possible)
maybe I'm overthinking, to me it could sound confusing as if we automatically will send logs when this is enabled
There was a problem hiding this comment.
Yeah I get how this feels confusing, but I think for now it's fine, especially since we don't mention that we are adding any instrumentation, just enabling application logs to be sent.
# Conflicts: # CHANGELOG.md
Closes #1038