Skip to content

feat(nuxt): deactivate error button when adblocker is detected in example page - #1019

Merged
shellmayr merged 4 commits into
masterfrom
shellmayr/feat/deactivate-example-page-error-button-when-disconnected-nuxt
Jul 2, 2025
Merged

shellmayr merged 4 commits into
masterfrom
shellmayr/feat/deactivate-example-page-error-button-when-disconnected-nuxt

Conversation

@shellmayr

Copy link
Copy Markdown
Member

Connection successful:
Screenshot 2025-07-02 at 13 38 51

Connection failed:
Screenshot 2025-07-02 at 13 38 46
Closes TET-776

@github-actions

github-actions Bot commented Jul 2, 2025 •

Copy link
Copy Markdown
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against e16d167

@codecov

codecov Bot commented Jul 2, 2025 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.03%. Comparing base (0391578) to head (e16d167).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/nuxt/templates.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1019      +/-   ##
==========================================
- Coverage   28.09%   28.03%   -0.07%     
==========================================
  Files         130      130              
  Lines       14252    14252              
  Branches      890      890              
==========================================
- Hits         4004     3995       -9     
- Misses      10231    10240       +9     
  Partials       17       17              
Flag Coverage Δ
unit-tests 28.03% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shellmayr
shellmayr requested a review from a team July 2, 2025 11:43
@shellmayr
shellmayr marked this pull request as ready for review July 2, 2025 11:43
@shellmayr
shellmayr force-pushed the shellmayr/feat/deactivate-example-page-error-button-when-disconnected-nuxt branch from 20373ba to e16d167 Compare July 2, 2025 12:13
@shellmayr
shellmayr merged commit c7f9750 into master Jul 2, 2025
@shellmayr
shellmayr deleted the shellmayr/feat/deactivate-example-page-error-button-when-disconnected-nuxt branch July 2, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants