Skip to content

feat(remix): deactivate error button when adblocker is detected in example page - #1017

Merged
shellmayr merged 2 commits into
masterfrom
shellmayr/feat/deactivate-example-page-error-button-when-disconnected-remix
Jul 2, 2025
Merged

shellmayr merged 2 commits into
masterfrom
shellmayr/feat/deactivate-example-page-error-button-when-disconnected-remix

Conversation

@shellmayr

@shellmayr shellmayr commented Jul 2, 2025 •

Copy link
Copy Markdown
Member

Successful connection:
Screenshot 2025-07-02 at 13 01 51

Blocked Connection:
Screenshot 2025-07-02 at 13 01 42

Closes TET-777

@shellmayr shellmayr changed the title feat(remix): deactivate error button when adblocker is detected in ex… feat(remix): deactivate error button when adblocker is detected in example page Jul 2, 2025
@github-actions

github-actions Bot commented Jul 2, 2025 •

Copy link
Copy Markdown
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against fed960e

@codecov

codecov Bot commented Jul 2, 2025 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.09%. Comparing base (ac6df3b) to head (fed960e).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/remix/sdk-example.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1017      +/-   ##
==========================================
- Coverage   28.09%   28.09%   -0.01%     
==========================================
  Files         130      130              
  Lines       14251    14252       +1     
  Branches      890      890              
==========================================
  Hits         4004     4004              
- Misses      10230    10231       +1     
  Partials       17       17              
Flag Coverage Δ
unit-tests 28.09% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shellmayr
shellmayr marked this pull request as ready for review July 2, 2025 11:05
@shellmayr
shellmayr requested a review from a team July 2, 2025 11:05
@shellmayr
shellmayr merged commit a02f160 into master Jul 2, 2025
@shellmayr
shellmayr deleted the shellmayr/feat/deactivate-example-page-error-button-when-disconnected-remix branch July 2, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants