feat(huggingface_hub): Gate prompt/response collection on data_collection option - #7172
Open
ericapisani wants to merge 5 commits into
Open
feat(huggingface_hub): Gate prompt/response collection on data_collection option#7172ericapisani wants to merge 5 commits into
ericapisani wants to merge 5 commits into
Conversation
…tion option Prompts, response text, tool calls, and available tools are now gated on the `data_collection.gen_ai.inputs`/`outputs` experiment when configured, falling back to the existing `send_default_pii`/`include_prompts` check otherwise. Refs PY-2588 Refs #6748
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2ec0d48. Configure here.
Drop the shared DATA_COLLECTION_PARAMS/DATA_COLLECTION_PARAM_NAMES constants and write the parameter names and cases directly in each test's parametrize decorator.
Drop _expected_keys and _get_gen_ai_span_data. Each parametrized case now lists the expected present and absent span attributes explicitly, and the streaming/non-streaming span lookup lives in each test body.
The DATA_COLLECTION_* constants were interleaved with the tests that used them. Move them into a single block ahead of the data collection tests.
The four DATA_COLLECTION_*_EXPECTED_VALUES dicts were each used by one test. Move them into the test bodies as expected_values; DATA_COLLECTION_TOOLS stays module-level since two tests share it.
Contributor
Codecov Results 📊✅ 104962 passed | ⏭️ 6677 skipped | Total: 111639 | Pass Rate: 94.02% | Execution Time: 361m 25s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2478 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 90.14% 90.17% +0.03%
==========================================
Files 193 193 —
Lines 25183 25211 +28
Branches 9176 9210 +34
==========================================
+ Hits 22700 22733 +33
- Misses 2483 2478 -5
- Partials 1429 1431 +2Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prompts, response text, tool calls, and available tools are now gated on the
data_collection.gen_ai.inputs/outputsexperiment when configured, falling back to the existingsend_default_pii/include_promptscheck otherwise.Refs PY-2588
Refs #6748