Skip to content

feat: Remove early return for NoOpStreamedSpan in set_transaction_name #7164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexander-alderman-webb wants to merge 2 commits into from
+1 −4
Open

feat: Remove early return for NoOpStreamedSpan in set_transaction_name #7164

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70b1a77
feat: Remove early return for NoOpStreamedSpan in set_transaction_name
alexander-alderman-webb Aug 11, 2026
c9981ae
Merge branch 'webb/set-transaction-on-scope' into webb/remove-set-tra…
alexander-alderman-webb Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions sentry_sdk/scope.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -861,10 +861,7 @@ def set_transaction_name(self, name: str, source: "Optional[str]" = None) -> Non
"""Set the transaction name and optionally the transaction source."""
self._transaction = name
if self._span:
if isinstance(self._span, NoOpStreamedSpan):
return

elif isinstance(self._span, StreamedSpan):
if isinstance(self._span, StreamedSpan):
self._span._segment.name = name
if source:
self._span._segment.set_attribute(
Expand Down
Loading