fix(batcher): Add global flush trigger based on the span number - #7150
Merged
alexander-alderman-webb merged 2 commits intoAug 10, 2026
Merged
Conversation
alexander-alderman-webb
marked this pull request as ready for review
August 10, 2026 12:34
sentrivana
approved these changes
Aug 10, 2026
Contributor
Codecov Results 📊✅ 99590 passed | ⏭️ 6671 skipped | Total: 106261 | Pass Rate: 93.72% | Execution Time: 345m 6s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2502 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.99% 90.02% +0.03%
==========================================
Files 193 193 —
Lines 25073 25074 +1
Branches 9066 9066 —
==========================================
+ Hits 22564 22572 +8
- Misses 2509 2502 -7
- Partials 1440 1440 —Generated by Codecov Action |
alexander-alderman-webb
deleted the
webb/batcher/add-global-flush-trigger
branch
August 10, 2026 12:49
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I realized we would be dropping spans if we reach
GLOBAL_MAX_BEFORE_DROPspans before reaching the bytes limit at which we flush spans.Add a global span limit to trigger a batcher flush. This mirrors the per-bucket logic.
Add a test for the global span limit based on the test for the per-bucket limit.
Add
test_span_number_reset_after_length_based_flushing()to ensure accurate bookkeeping of the total estimated size of spans in the batcher.Issues
Reminders
uv run ruff.feat:,fix:,ref:,meta:)