feat(batcher): Add hard span limit - #7143
Merged
alexander-alderman-webb merged 5 commits intoAug 10, 2026
Merged
Conversation
Contributor
Codecov Results 📊✅ 101547 passed | ⏭️ 6635 skipped | Total: 108182 | Pass Rate: 93.87% | Execution Time: 353m 45s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 83.33%. Project has 2498 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 90.02% 90.01% -0.01%
==========================================
Files 193 193 —
Lines 25010 25014 +4
Branches 9032 9032 —
==========================================
+ Hits 22514 22516 +2
- Misses 2496 2498 +2
- Partials 1434 1435 +1Generated by Codecov Action |
alexander-alderman-webb
marked this pull request as ready for review
August 10, 2026 07:11
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit faf5684. Configure here.
sentrivana
approved these changes
Aug 10, 2026
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a hard span limit after which new spans are not added to the batcher. This mirrors the per-bucket logic.
This aims to keep memory use bounded at a multiple of the size of live
StreamedSpanobjects.Adapt the
test_drop_after_max_reached()test which tests the per-bucket span limit to a test which tests the global span limit. Also add thetest_capture_after_flush_with_global_limit()to ensure accurate bookkeeping to track the number of spans in the batcher.Issues
Reminders
uv run ruff.feat:,fix:,ref:,meta:)