Skip to content

fix: Dont crash on breadcrumb overflow #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
untitaker merged 1 commit into from
Sep 21, 2018
Merged

fix: Dont crash on breadcrumb overflow #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sentry_sdk/hub.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,8 @@ def add_breadcrumb(self, crumb=None, hint=None, **kwargs):
scope._breadcrumbs.append(crumb)
else:
logger.info("before breadcrumb dropped breadcrumb (%s)", original_crumb)
while len(scope._breadcrumbs) >= client.options["max_breadcrumbs"]:
scope._breadcrumbs.popleft()
while len(scope._breadcrumbs) > client.options["max_breadcrumbs"]:
scope._breadcrumbs.pop(0)

def push_scope(self, callback=None):
"""Pushes a new layer on the scope stack. Returns a context manager
Expand Down
17 changes: 17 additions & 0 deletions tests/test_basics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,3 +139,20 @@ def test_push_scope_null_client(sentry_init, capture_events):
capture_exception(e)

assert len(events) == 0


def test_breadcrumbs_overflow(sentry_init, capture_events):
sentry_init(max_breadcrumbs=10)

for i in range(20):
add_breadcrumb(
category="auth", message="Authenticated user %s" % i, level="info"
)

events = capture_events()

capture_exception(ValueError())

event, = events

assert len(event["breadcrumbs"]) == 10