Repository navigation
test: Add span origin span streaming tests - #6697
Merged
Merged
Conversation
sentrivana
marked this pull request as ready for review
June 30, 2026 12:53
Contributor
Codecov Results 📊✅ 89952 passed | ⏭️ 6288 skipped | Total: 96240 | Pass Rate: 93.47% | Execution Time: 312m 44s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2435 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.77% 89.77% —%
==========================================
Files 192 192 —
Lines 23809 23809 —
Branches 8218 8218 —
==========================================
+ Hits 21374 21374 —
- Misses 2435 2435 —
- Partials 1347 1347 —Generated by Codecov Action |
alexander-alderman-webb
approved these changes
Jun 30, 2026
6 tasks
mgaligniana
pushed a commit
to mgaligniana/sentry-python
that referenced
this pull request
Aug 9, 2026
### Description Span origin is just a regular attribute in span streaming, so it might not actually need separate tests. However, the case where we check that it's set to `manual` by default makes sense to cover, so added streaming counterparts to the two existing origin tests. #### Issues Part of getsentry#5395 #### Reminders - Please add tests to validate your changes, and lint your code using `uv run ruff`. - Add GH Issue ID _&_ Linear ID (if applicable) - PR title should use [conventional commit](https://develop.sentry.dev/engineering-practices/commit-messages/#type) style (`feat:`, `fix:`, `ref:`, `meta:`) - For external contributors: [CONTRIBUTING.md](https://github.com/getsentry/sentry-python/blob/master/CONTRIBUTING.md), [Sentry SDK development docs](https://develop.sentry.dev/sdk/), [Discord community](https://discord.gg/Ww9hbqr)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Span origin is just a regular attribute in span streaming, so it might not actually need separate tests. However, the case where we check that it's set to
manualby default makes sense to cover, so added streaming counterparts to the two existing origin tests.Issues
Part of #5395
Reminders
uv run ruff.feat:,fix:,ref:,meta:)