fix(tests): Fix flaky OTel propagator entry point test#6655
Open
ericapisani wants to merge 3 commits into
Open
fix(tests): Fix flaky OTel propagator entry point test#6655ericapisani wants to merge 3 commits into
ericapisani wants to merge 3 commits into
Conversation
The old test used `importlib.reload(propagate)` with a patched `OTEL_PROPAGATORS` env var, which was flaky because OTel's `_importlib_metadata` module caches `entry_points()` with `@functools.cache`. Depending on when the cache was first populated, the "sentry" entry point might not be found during the reload. Replace with a direct `importlib.metadata.entry_points()` query that verifies the entry point is registered, has the correct value, and loads to `SentryPropagator`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use importlib_metadata backport fallback for Python 3.7, and handle the dict return type from entry_points() on older Python versions where keyword filtering isn't supported. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Editable installs on some Python versions register the entry point twice (via setup.py and dist-info). Assert >= 1 match instead of exactly 1. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Codecov Results 📊✅ 89837 passed | ⏭️ 6240 skipped | Total: 96077 | Pass Rate: 93.51% | Execution Time: 318m 51s 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2402 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.89% 89.89% —%
==========================================
Files 192 192 —
Lines 23763 23763 —
Branches 8206 8206 —
==========================================
+ Hits 21360 21361 +1
- Misses 2403 2402 -1
- Partials 1343 1342 -1Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related flaky test run: https://github.com/getsentry/sentry-python/actions/runs/28110662230/job/83239750332
Summary
test_propagator_loaded_if_mentioned_in_environment_variablein thepoteltest suiteimportlib.reload(propagate)with a patched env var, which was flaky because OTel's_importlib_metadatacachesentry_points()with@functools.cacheimportlib.metadata.entry_points()query that verifies registration, value, and loaded class