fix(asgi): Add url.path to ASGI request span attributes#6652
Open
ericapisani wants to merge 1 commit into
Open
fix(asgi): Add url.path to ASGI request span attributes#6652ericapisani wants to merge 1 commit into
ericapisani wants to merge 1 commit into
Conversation
The ASGI integration was missing the url.path attribute on streamed request spans. Add it by concatenating root_path and path from the ASGI scope, which correctly handles sub-mounted apps where root_path is non-empty. Refs PY-2551 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Codecov Results 📊✅ 89842 passed | ⏭️ 6240 skipped | Total: 96082 | Pass Rate: 93.51% | Execution Time: 320m 42s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2396 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.89% 89.92% +0.03%
==========================================
Files 192 192 —
Lines 23763 23764 +1
Branches 8206 8206 —
==========================================
+ Hits 21360 21368 +8
- Misses 2403 2396 -7
- Partials 1343 1343 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ASGI integration was not setting
url.pathon streamed request spans. Add it by combiningroot_pathandpathfrom the ASGI scope, which correctly handles sub-mounted apps whereroot_pathis non-empty.Fixes PY-2551
Fixes #6651