fix: Stop unconditionally importing contextvars#6625
Open
alexander-alderman-webb wants to merge 2 commits into
Open
fix: Stop unconditionally importing contextvars#6625alexander-alderman-webb wants to merge 2 commits into
contextvars#6625alexander-alderman-webb wants to merge 2 commits into
Conversation
Contributor
Codecov Results 📊✅ 91382 passed | ⏭️ 6136 skipped | Total: 97518 | Pass Rate: 93.71% | Execution Time: 326m 30s 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2404 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.85% 89.88% +0.03%
==========================================
Files 192 192 —
Lines 23745 23744 -1
Branches 8198 8198 —
==========================================
+ Hits 21334 21340 +6
- Misses 2411 2404 -7
- Partials 1344 1344 —Generated by Codecov Action |
ericapisani
approved these changes
Jun 22, 2026
ericapisani
left a comment
Member
There was a problem hiding this comment.
LGTM. I noticed that the pydantic integration still directly imports from contextvars, but I think it shouldn't be an issue given our minimum support version of python for that is 3.10
contextvars
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix regression from 2604409.
contextvarswas added to the standard library in Python 3.7, andsentry-sdkdoes not declare any dependencies which allow it to resolvecontextvarsat import time.Issues
Reminders
uv run ruff.feat:,fix:,ref:,meta:)