Skip to content

ci: Remove brotli from requirements-testing.txt #6614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
alexander-alderman-webb wants to merge 3 commits into
base: master
Choose a base branch
from
+10 −2
Draft

ci: Remove brotli from requirements-testing.txt #6614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e0c0ee
ci: Remove brotli from requirements-testing.txt
alexander-alderman-webb Jun 22, 2026
579a31f
import fallback
alexander-alderman-webb Jun 22, 2026
22091bc
.
alexander-alderman-webb Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion requirements-testing.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,4 @@ pysocks
socksio
httpcore[http2]
setuptools
Brotli
docker
2 changes: 2 additions & 0 deletions scripts/populate_tox/tox.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ deps =

# === Common ===
py3.8-common: hypothesis
common: brotli
common: pytest-asyncio
common: httpcore[asyncio]
# See https://github.com/pytest-dev/pytest/issues/9621
Expand All @@ -97,6 +98,7 @@ deps =
# for justification of the upper bound on pytest
{py3.6,py3.7}-gevent: pytest<7.0.0
{py3.8,py3.9,py3.10,py3.11,py3.12}-gevent: pytest
gevent: brotli
gevent: pytest-asyncio
gevent: setuptools<82
{py3.10,py3.11}-gevent: zope.event<5.0.0
Expand Down
7 changes: 6 additions & 1 deletion tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,11 @@
from unittest import mock
from urllib.parse import parse_qs, urlparse

import brotli
try:
import brotli
except ImportError:
brotli = None

import jsonschema
import pytest
from pytest_localserver.http import WSGIServer
Expand Down Expand Up @@ -1641,6 +1645,7 @@ def __call__(self, environ, start_response):
rdr = gzip.GzipFile(fileobj=io.BytesIO(request.data))
compressed = True
elif content_encoding == "br":
assert brotli is not None
rdr = io.BytesIO(brotli.decompress(request.data))
compressed = True
else:
Expand Down
2 changes: 2 additions & 0 deletions tox.ini
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.