Skip to content

ci: Remove pytest-timeout from requirements-testing.txt #6613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
alexander-alderman-webb wants to merge 1 commit into
base: master
Choose a base branch
from
+0 −1
Draft

ci: Remove pytest-timeout from requirements-testing.txt #6613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion requirements-testing.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ tomli;python_version<"3.11" # Only needed for pytest on Python < 3.11
pytest-cov
pytest-forked
pytest-localserver
pytest-timeout
Comment thread
alexander-alderman-webb marked this conversation as resolved.
pytest-watch

@sentry sentry Bot Jun 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Removing pytest-timeout breaks a deadlock regression test which relies on the @pytest.mark.timeout decorator to prevent it from hanging.
Severity: MEDIUM

Suggested Fix

Do not remove the pytest-timeout package from requirements-testing.txt. It is a necessary dependency for the regression test test_reentrant_add_does_not_deadlock to function correctly and prevent CI hangs.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: requirements-testing.txt#L7

Potential issue: The pull request removes the `pytest-timeout` package from
`requirements-testing.txt`, but this package is actively used. Specifically, the test
`test_reentrant_add_does_not_deadlock` in `tests/test_logs.py` uses the
`@pytest.mark.timeout(5)` decorator to guard against a known deadlock regression.
Without the `pytest-timeout` package, pytest will ignore this decorator, causing the
test to hang indefinitely if the deadlock reoccurs. This would disable a critical
regression test and could block the CI pipeline instead of providing a fast failure.

Did we get this right? 👍 / 👎 to inform future reviews.

@alexander-alderman-webb alexander-alderman-webb Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate of #6613 (comment)

jsonschema
executing
Expand Down
Loading