ci: Remove pytest-timeout from requirements-testing.txt#6613
ci: Remove pytest-timeout from requirements-testing.txt#6613alexander-alderman-webb wants to merge 1 commit into
pytest-timeout from requirements-testing.txt#6613Conversation
pytest-timeout from requirements-testing.txt
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0103ee3. Configure here.
| pytest-forked | ||
| pytest-localserver | ||
| pytest-timeout | ||
| pytest-watch |
There was a problem hiding this comment.
Bug: Removing pytest-timeout breaks a deadlock regression test which relies on the @pytest.mark.timeout decorator to prevent it from hanging.
Severity: MEDIUM
Suggested Fix
Do not remove the pytest-timeout package from requirements-testing.txt. It is a necessary dependency for the regression test test_reentrant_add_does_not_deadlock to function correctly and prevent CI hangs.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: requirements-testing.txt#L7
Potential issue: The pull request removes the `pytest-timeout` package from
`requirements-testing.txt`, but this package is actively used. Specifically, the test
`test_reentrant_add_does_not_deadlock` in `tests/test_logs.py` uses the
`@pytest.mark.timeout(5)` decorator to guard against a known deadlock regression.
Without the `pytest-timeout` package, pytest will ignore this decorator, causing the
test to hang indefinitely if the deadlock reoccurs. This would disable a critical
regression test and could block the CI pipeline instead of providing a fast failure.
Did we get this right? 👍 / 👎 to inform future reviews.
Codecov Results 📊✅ 91382 passed | ⏭️ 6136 skipped | Total: 97518 | Pass Rate: 93.71% | Execution Time: 315m 13s 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2409 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.84% 89.85% +0.01%
==========================================
Files 192 192 —
Lines 23745 23745 —
Branches 8198 8198 —
==========================================
+ Hits 21334 21336 +2
- Misses 2411 2409 -2
- Partials 1344 1343 -1Generated by Codecov Action |
Description
The package doesn't seem to be used.
Issues
Reminders
uv run ruff.feat:,fix:,ref:,meta:)