Skip to content

feat(ray): Support span streaming #6518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexander-alderman-webb wants to merge 6 commits into
base: master
Choose a base branch
from
+437 −135
Open

feat(ray): Support span streaming #6518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
49fafc3
feat(ray): Support span streaming
alexander-alderman-webb Jun 8, 2026
c752264
.
alexander-alderman-webb Jun 8, 2026
dbf413f
add flush
alexander-alderman-webb Jun 8, 2026
565358e
.
alexander-alderman-webb Jun 8, 2026
278e7a4
.
alexander-alderman-webb Jun 8, 2026
a53ce3e
.
alexander-alderman-webb Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
136 changes: 97 additions & 39 deletions sentry_sdk/integrations/ray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
import sentry_sdk
from sentry_sdk.consts import OP, SPANSTATUS
from sentry_sdk.integrations import DidNotEnable, Integration, _check_minimum_version
from sentry_sdk.traces import SegmentSource
from sentry_sdk.tracing import TransactionSource
from sentry_sdk.tracing_utils import has_span_streaming_enabled
from sentry_sdk.utils import (
event_from_exception,
logger,
Expand Down Expand Up @@ -88,25 +90,52 @@ def new_func(
) -> "Any":
_check_sentry_initialized()

transaction = sentry_sdk.continue_trace(
_sentry_tracing or {},
op=OP.QUEUE_TASK_RAY,
name=qualname_from_function(user_f),
origin=RayIntegration.origin,
source=TransactionSource.TASK,
span_streaming = has_span_streaming_enabled(
sentry_sdk.get_client().options
)

with sentry_sdk.start_transaction(transaction) as transaction:
try:
result = user_f(*f_args, **f_kwargs)
transaction.set_status(SPANSTATUS.OK)
except Exception:
transaction.set_status(SPANSTATUS.INTERNAL_ERROR)
exc_info = sys.exc_info()
_capture_exception(exc_info)
reraise(*exc_info)

return result
if span_streaming:
sentry_sdk.traces.continue_trace(_sentry_tracing or {})

function_name = qualname_from_function(user_f)
with sentry_sdk.traces.start_span(
name="unknown Ray task"
if function_name is None
else function_name,
attributes={
"sentry.op": OP.QUEUE_TASK_RAY,
"sentry.origin": RayIntegration.origin,
"sentry.span.source": SegmentSource.TASK,
},
parent_span=None,
):
try:
result = user_f(*f_args, **f_kwargs)
except Exception:
Copy link
Copy Markdown
Contributor

@sentrivana sentrivana Jun 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we set the span status to error here or is that already happening somewhere in the helper methods?

Copy link
Copy Markdown
Contributor Author

@alexander-alderman-webb alexander-alderman-webb Jun 8, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The span status is set to error in StreamedSpan.__exit__() since we use the with ...: construct.

The integration has had this manual status management since the start (#2444), so I am assumed this isn't behavior we wish to keep (but please let me know if I'm missing something).

The only functional difference is when the exception is in the list used by should_be_treated_as_error().

exc_info = sys.exc_info()
_capture_exception(exc_info)
reraise(*exc_info)
Comment thread
alexander-alderman-webb marked this conversation as resolved.

return result
else:
transaction = sentry_sdk.continue_trace(
_sentry_tracing or {},
op=OP.QUEUE_TASK_RAY,
name=qualname_from_function(user_f),
origin=RayIntegration.origin,
source=TransactionSource.TASK,
)

with sentry_sdk.start_transaction(transaction) as transaction:
try:
result = user_f(*f_args, **f_kwargs)
transaction.set_status(SPANSTATUS.OK)
except Exception:
transaction.set_status(SPANSTATUS.INTERNAL_ERROR)
exc_info = sys.exc_info()
_capture_exception(exc_info)
reraise(*exc_info)

return result

_insert_sentry_tracing_in_signature(new_func)

Expand All @@ -122,27 +151,56 @@ def _remote_method_with_header_propagation(
"""
Ray Client
"""
with sentry_sdk.start_span(
op=OP.QUEUE_SUBMIT_RAY,
name=qualname_from_function(user_f),
origin=RayIntegration.origin,
) as span:
tracing = {
k: v
for k, v in sentry_sdk.get_current_scope().iter_trace_propagation_headers()
}
try:
result = old_remote_method(
*args, **kwargs, _sentry_tracing=tracing
)
span.set_status(SPANSTATUS.OK)
except Exception:
span.set_status(SPANSTATUS.INTERNAL_ERROR)
exc_info = sys.exc_info()
_capture_exception(exc_info)
reraise(*exc_info)

return result
span_streaming = has_span_streaming_enabled(
sentry_sdk.get_client().options
)
if span_streaming:
function_name = qualname_from_function(user_f)
with sentry_sdk.traces.start_span(
name="unknown Ray task"
if function_name is None
else function_name,
attributes={
"sentry.op": OP.QUEUE_SUBMIT_RAY,
"sentry.origin": RayIntegration.origin,
},
):
tracing = {
k: v
for k, v in sentry_sdk.get_current_scope().iter_trace_propagation_headers()
}
try:
result = old_remote_method(
*args, **kwargs, _sentry_tracing=tracing
)
except Exception:
Copy link
Copy Markdown
Contributor

@sentrivana sentrivana Jun 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same q re: setting span status to error

exc_info = sys.exc_info()
_capture_exception(exc_info)
reraise(*exc_info)

return result
else:
with sentry_sdk.start_span(
op=OP.QUEUE_SUBMIT_RAY,
name=qualname_from_function(user_f),
origin=RayIntegration.origin,
) as span:
tracing = {
k: v
for k, v in sentry_sdk.get_current_scope().iter_trace_propagation_headers()
}
try:
result = old_remote_method(
*args, **kwargs, _sentry_tracing=tracing
)
span.set_status(SPANSTATUS.OK)
except Exception:
span.set_status(SPANSTATUS.INTERNAL_ERROR)
exc_info = sys.exc_info()
_capture_exception(exc_info)
reraise(*exc_info)

return result

rv.remote = _remote_method_with_header_propagation

Expand Down
Loading
Loading