fix(asgi): Gate query string and client IP behind send_default_pii#6501
Open
ericapisani wants to merge 2 commits into
Open
fix(asgi): Gate query string and client IP behind send_default_pii#6501ericapisani wants to merge 2 commits into
ericapisani wants to merge 2 commits into
Conversation
Move http.query and client.address attribute collection inside the should_send_default_pii() check so sensitive values are not captured by default. Fixes PY-2514 Fixes #6499
Member
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 666e6fb. Configure here.
Contributor
Codecov Results 📊✅ 88436 passed | ⏭️ 6022 skipped | Total: 94458 | Pass Rate: 93.62% | Execution Time: 298m 12s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2481 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 89.38% 89.35% -0.03%
==========================================
Files 192 192 —
Lines 23285 23286 +1
Branches 8002 8004 +2
==========================================
+ Hits 20811 20805 -6
- Misses 2474 2481 +7
- Partials 1309 1309 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move http.query and client.address attribute collection inside the
should_send_default_pii() check so sensitive values are not captured
by default.
Fixes PY-2514
Fixes #6499