Skip to content

test(aiohttp): Unfurl spans explicitly instead of using pop() #6435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sentrivana wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −12
Draft

test(aiohttp): Unfurl spans explicitly instead of using pop() #6435

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 5 additions & 12 deletions tests/integrations/aiohttp/test_aiohttp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1226,8 +1226,7 @@ async def hello(request):

sentry_sdk.flush()

items.pop() # drop the test client's outer segment
(server_span,) = [item.payload for item in items]
server_span, _client_segment = [item.payload for item in items]

# send_default_pii defaults to False, so _filter_headers substitutes
# sensitive headers with SENSITIVE_DATA_SUBSTITUTE ("[Filtered]"). The
Expand Down Expand Up @@ -1267,8 +1266,7 @@ async def hello(request):

sentry_sdk.flush()

items.pop() # drop the test client's outer segment
(server_span,) = [item.payload for item in items]
server_span, _client_segment = [item.payload for item in items]

# With send_default_pii=True, _filter_headers is a no-op and the original
# value reaches the span attribute.
Expand Down Expand Up @@ -1396,10 +1394,7 @@ async def hello(request):
assert error_event.type == "event"
assert error_event.payload["exception"]["values"][0]["type"] == "ZeroDivisionError"

spans = items[1:]
assert spans[-1].type == "span"
segment = spans.pop().payload
(server_span,) = [item.payload for item in spans]
server_span, segment = [item.payload for item in items[1:]]

assert segment["is_segment"] is True
assert segment["attributes"]["sentry.op"] == "http.client"
Expand Down Expand Up @@ -1441,8 +1436,7 @@ async def hello(request):
sentry_sdk.flush()

assert len(items) == 2
segment = items.pop().payload
(server_span,) = [item.payload for item in items]
server_span, segment = [item.payload for item in items]

assert segment["is_segment"] is True
assert segment["attributes"]["sentry.op"] == "http.client"
Expand Down Expand Up @@ -1479,8 +1473,7 @@ async def hello(request):
sentry_sdk.flush()

assert len(items) == 2
segment = items.pop().payload
(server_span,) = [item.payload for item in items]
server_span, segment = [item.payload for item in items]

assert segment["is_segment"] is True
assert segment["attributes"]["sentry.op"] == "http.client"
Expand Down
Loading