feat(dramatiq): Support span streaming#6273
Draft
sl0thentr0py wants to merge 1 commit into
Draft
Conversation
Contributor
Codecov Results 📊✅ 282 passed | Total: 282 | Pass Rate: 100% | Execution Time: 42.85s All tests are passing successfully. ❌ Patch coverage is 0.00%. Project has 14784 uncovered lines. Files with missing lines (1)
Generated by Codecov Action |
Add a span-streaming branch in SentryMiddleware.before_process_message and after_process_message alongside the legacy transaction-based path, gated on has_span_streaming_enabled. The streaming branch uses sentry_sdk.traces.continue_trace + start_span and stashes the span context manager on the message so the after-hook can exit it without relying on scope.transaction (which doesn't exist in streaming mode). Parametrize the tracing tests over span_streaming True/False so both modes are covered. Refs GH-5386 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
31489ea to
326b013
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a span-streaming branch in SentryMiddleware.before_process_message
and after_process_message alongside the legacy transaction-based path,
gated on has_span_streaming_enabled. The streaming branch uses
sentry_sdk.traces.continue_trace + start_span and stashes the span
context manager on the message so the after-hook can exit it without
relying on scope.transaction (which doesn't exist in streaming mode).
Parametrize the tracing tests over span_streaming True/False so both
modes are covered.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com
Issues