fix: Make contextvars-detection more readable#574
Merged
Conversation
rhcarvalho
approved these changes
Dec 10, 2019
Contributor
rhcarvalho
left a comment
There was a problem hiding this comment.
Definitely more explicit now! Thanks @untitaker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rhcarvalho and I were guessing at how the code actually worked. It seemed like it only did so accidentally because the import of
aiocontextvarshas the side effect of monkeypatchingcontextvars(the PyPI package, not the stdlib module!) which is one of its dependencies.