Repository navigation
fix(integrations/dramatiq): use set_transaction_name - #4175
Merged
sentrivana merged 2 commits intoMar 25, 2025
Merged
Conversation
The Dramatiq integration is using a deprecated method to set the scope's transaction name, use set_transaction_name instead. "Assigning to scope.transaction directly is deprecated: use scope.set_transaction_name() instead."
sentrivana
approved these changes
Mar 25, 2025
sentrivana
left a comment
Collaborator
There was a problem hiding this comment.
Thank you @timdrijvers!
sentrivana
enabled auto-merge (squash)
March 25, 2025 13:20
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4175 +/- ##
==========================================
+ Coverage 79.57% 79.58% +0.01%
==========================================
Files 141 141
Lines 15737 15737
Branches 2675 2675
==========================================
+ Hits 12522 12525 +3
+ Misses 2369 2367 -2
+ Partials 846 845 -1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Dramatiq integration is using a deprecated method to set the scope's transaction name, use set_transaction_name instead.
"Assigning to scope.transaction directly is deprecated: use scope.set_transaction_name() instead."