Skip to content

ref: Change argument order for hint and scope #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitsuhiko merged 1 commit into from
Aug 31, 2018
+6 −6
Merged

ref: Change argument order for hint and scope #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions sentry_sdk/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def disabled(cls):
"""Creates a guarnateed to be disabled client."""
return cls(NO_DSN)

def _prepare_event(self, event, scope, hint=None):
def _prepare_event(self, event, hint, scope):
if event.get("timestamp") is None:
event["timestamp"] = datetime.utcnow()

Expand Down Expand Up @@ -135,7 +135,7 @@ def _is_ignored_error(self, event, hint=None):

return False

def _should_capture(self, event, scope=None, hint=None):
def _should_capture(self, event, hint=None, scope=None):
if (
self.options["sample_rate"] < 1.0
and random.random() >= self.options["sample_rate"]
Expand All @@ -147,15 +147,15 @@ def _should_capture(self, event, scope=None, hint=None):

return True

def capture_event(self, event, scope=None, hint=None):
def capture_event(self, event, hint=None, scope=None):
"""Captures an event."""
if self._transport is None:
return
rv = event.get("event_id")
if rv is None:
event["event_id"] = rv = uuid.uuid4().hex
if self._should_capture(event, scope, hint):
event = self._prepare_event(event, scope, hint)
if self._should_capture(event, hint, scope):
event = self._prepare_event(event, hint, scope)
if event is not None:
self._transport.capture_event(event)
return rv
Expand Down
2 changes: 1 addition & 1 deletion sentry_sdk/hub.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ def capture_event(self, event, hint=None):
"""Captures an event."""
client, scope = self._stack[-1]
if client is not None:
rv = client.capture_event(event, scope, hint)
rv = client.capture_event(event, hint, scope)
if rv is not None:
self._last_event_id = rv
return rv
Expand Down