Skip to content

feat(profiling): Continuous profiling sample rate#4002

Merged
Zylphrex merged 7 commits into
masterfrom
txiao/feat/continuous-profiling-sample-rate
Feb 4, 2025
Merged

feat(profiling): Continuous profiling sample rate#4002
Zylphrex merged 7 commits into
masterfrom
txiao/feat/continuous-profiling-sample-rate

Conversation

@Zylphrex
Copy link
Copy Markdown
Member

@Zylphrex Zylphrex commented Jan 28, 2025

This introduces a new top level setting for the continuous profiling session sample rate. The sample rate is evaluated once at the beginning and is used to determine whether or not the profiler will be run for the remainder of the process.

@Zylphrex
feat(profiling): Continuous profiling sample rate
c174f36 
This introduces a new top level setting for the continuous profiling session
sample rate. The sample rate is evaluated once at the beginning and is used to
determine whether or not the profiler will be run for the remainder of the
process.
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 31, 2025 •
edited
Loading

❌ 13 Tests Failed:

Tests completed Failed Passed Skipped
22148 13 22135 5756
View the top 3 failed tests by shortest run time 
tests.test_client test_uwsgi_warnings[opt6-missing_flags6]
Stack Traces | 0.275s run time 
tests/test_client.py:1331: in test_uwsgi_warnings
    assert len(recwarn) == 1
E   assert 2 == 1
E    +  where 2 = len(WarningsRecorder(record=True))
tests.test_client test_uwsgi_warnings[opt3-missing_flags3]
Stack Traces | 0.278s run time 
tests/test_client.py:1336: in test_uwsgi_warnings
    assert not recwarn
E   assert not WarningsRecorder(record=True)
tests.test_client test_uwsgi_warnings[opt2-missing_flags2]
Stack Traces | 0.284s run time 
tests/test_client.py:1336: in test_uwsgi_warnings
    assert not recwarn
E   assert not WarningsRecorder(record=True)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

sentrivana
sentrivana approved these changes Feb 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see one suggestion

Comment thread sentry_sdk/profiler/continuous_profiler.py Outdated
@Zylphrex Zylphrex merged commit 797e82f into master Feb 4, 2025
@Zylphrex Zylphrex deleted the txiao/feat/continuous-profiling-sample-rate branch February 4, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentrivana sentrivana sentrivana approved these changes

@antonpirker antonpirker Awaiting requested review from antonpirker

@sl0thentr0py sl0thentr0py Awaiting requested review from sl0thentr0py

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Zylphrex @sentrivana