Added name parameter to start_span() and deprecated description parameter.#3524
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3524 +/- ##
==========================================
+ Coverage 84.25% 84.28% +0.02%
==========================================
Files 136 136
Lines 13895 13900 +5
Branches 2938 2940 +2
==========================================
+ Hits 11707 11715 +8
+ Misses 1458 1456 -2
+ Partials 730 729 -1
|
6 tasks
sentrivana
approved these changes
Sep 12, 2024
name to start_span() and deprecated description.name parameter to start_span() and deprecated description parameter.
nijel
added a commit
to nijel/weblate
that referenced
this pull request
Oct 2, 2024
This was introduced in getsentry/sentry-python#3524 and description immediatelly started to throw depreciation error.
Merged
5 tasks
nijel
added a commit
to WeblateOrg/weblate
that referenced
this pull request
Oct 2, 2024
This was introduced in getsentry/sentry-python#3524 and description immediatelly started to throw depreciation error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To align our API with OpenTelementry. In OTel a span has no
descriptionbut aname.This only changes to user facing API, under the hood there is still everything using the
description. (This will then be changed with OTel)Docs PR: getsentry/sentry-docs#11332
Follow up PR that should be released at the same time: #3525
Fixes #3520