Skip to content

feat(integration): Add Falcon integration#346

Merged
untitaker merged 10 commits into
getsentry:masterfrom
jacobsvante:falcon-integration
Apr 23, 2019
Merged

feat(integration): Add Falcon integration#346
untitaker merged 10 commits into
getsentry:masterfrom
jacobsvante:falcon-integration

Conversation

@jacobsvante
Copy link
Copy Markdown
Contributor

@jacobsvante jacobsvante commented Apr 20, 2019 •
edited
Loading

Adds support for the Falcon web framework. Any feedback or suggestions would be greatly appreciated.

untitaker
untitaker requested changes Apr 21, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you! I left a few comments which I think need addressing before we can merge this. Also we need to update the docs at https://github.com/getsentry/sentry-docs, see getsentry/sentry-docs#867 for a recent example on how this works.

Comment thread sentry_sdk/integrations/falcon.py Outdated
Comment thread sentry_sdk/integrations/falcon.py Outdated
Comment thread sentry_sdk/integrations/falcon.py Outdated
Comment thread sentry_sdk/integrations/falcon.py
Comment thread sentry_sdk/integrations/falcon.py Outdated
Comment thread sentry_sdk/integrations/falcon.py Outdated
@untitaker
Copy link
Copy Markdown
Member

untitaker commented Apr 21, 2019

Also I think this integration doesn't work for Python 2, see CI.

@jacobsvante
Copy link
Copy Markdown
Contributor Author

jacobsvante commented Apr 22, 2019

Thanks for your useful feedback @untitaker, much appreciated ❤

untitaker
untitaker reviewed Apr 23, 2019
View reviewed changes
Comment thread tox.ini
jacobsvante
jacobsvante commented Apr 23, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@jacobsvante jacobsvante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All requested changes have been implemented.

@jacobsvante jacobsvante mentioned this pull request Apr 23, 2019
Merged
@jacobsvante
Copy link
Copy Markdown
Contributor Author

jacobsvante commented Apr 23, 2019

@untitaker docs PR can be found here: getsentry/sentry-docs#924

@untitaker untitaker merged commit ffa2afd into getsentry:master Apr 23, 2019
@untitaker
Copy link
Copy Markdown
Member

untitaker commented Apr 23, 2019

Will release 0.7.11 soon.

@untitaker
Copy link
Copy Markdown
Member

untitaker commented Apr 23, 2019

Thanks for this awesome integration @jmagnusson!

@jacobsvante
Copy link
Copy Markdown
Contributor Author

jacobsvante commented Apr 23, 2019

No probs - Thank you for the great feedback 😀

@jacobsvante jacobsvante deleted the falcon-integration branch April 23, 2019 11:42
@untitaker
Copy link
Copy Markdown
Member

untitaker commented Apr 23, 2019

0.7.11 is released and the docs are deployed as well: https://docs.sentry.io/platforms/python/falcon/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@untitaker untitaker untitaker approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jacobsvante @untitaker