feat(sessions): Remove deprecated functions#3424
Closed
szokeasaurusrex wants to merge 3 commits into
Closed
Conversation
Member
Author
|
Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time. ❌ Failed Test Results:Completed 13513 tests with View the full list of failed testspy3.8-gevent
|
sentrivana
previously approved these changes
Aug 9, 2024
Will have to re-review this after looking at the prereq PR -- didn't realize these functions are not deprecated atm.
antonpirker
reviewed
Aug 9, 2024
Contributor
antonpirker
left a comment
There was a problem hiding this comment.
See my comment in #3419
Deprecate the Hub-based `is_auto_session_tracking_enabled` and the Scope-based `is_auto_session_tracking_enabled_scope`, and replace them with a new Scope-based private-API equivalent. Partially implements #3417
Make several changes to prepare for fully removing Hubs in the next major: - Deprecate the Hub-based `auto_session_tracking` function, replacing it with a new Scope-based function called `track_session` - Deprecate the scope-based `auto_session_tracking_scope` in favor of the new `track_session` function - Change usages of `auto_session_tracking_scope` to `track_sessions`. There are no usages of `auto_session_tracking` outside of tests. - Run all tests that were previously run against `auto_session_tracking` also against the new `track_session`. Previously, `auto_session_tracking_scope` was completely untested. Fixes #3417
Remove the deprecated functions from `sessions.py` (this includes all Hub-based logic) and all tests for these functions. BREAKING CHANGE: Remove `sentry_sdk.sessions.auto_session_tracking`. BREAKING CHANGE: Remove `sentry_sdk.sessions.is_auto_session_tracking_enabled`. BREAKING CHANGE: Remove `sentry_sdk.sessions.is_auto_session_tracking_enabled_scope`. BREAKING CHANGE: Remove `sentry_sdk.sessions.is_auto_session_tracking_enabled_scope`. Closes: #3416
85cb6d0 to
ef1bc38
Compare
Contributor
|
As this has been implemented here:
I will close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the deprecated functions from
sessions.py(this includes all Hub-based logic) and all tests for these functions.BREAKING CHANGE: Remove
sentry_sdk.sessions.auto_session_tracking.BREAKING CHANGE: Remove
sentry_sdk.sessions.is_auto_session_tracking_enabled.BREAKING CHANGE: Remove
sentry_sdk.sessions.is_auto_session_tracking_enabled_scope.BREAKING CHANGE: Remove
sentry_sdk.sessions.is_auto_session_tracking_enabled_scope.Closes: #3416