Remove unnecessary TYPE_CHECKING alias#2467
Merged
Merged
Conversation
Contributor
|
Thanks @rafrafek! |
Contributor
|
The change looks good but unfortunately the aws lambda tests are failing (not because of your change), we'll need to fix this before we can merge this. @antonpirker maybe you have an idea what's wrong? Is this maybe because this is a contributor PR? New PRs of Sentry folks don't have this issue, so maybe something auth related? |
sentrivana
approved these changes
Nov 3, 2023
Contributor
|
Created #2487 to track progress on the aws lambda test suite issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change was already proposed by @aqeelat in #1934 but it was not implemented.