Serialize local vars early on#2117
Closed
sentrivana wants to merge 2 commits into
Closed
Conversation
No need to have actual references floating around.
Contributor
Author
|
Closing, I think I found a better way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No need to have actual references floating around. This also helps us avoid tampering with the underlying objects by mistake later on.
The "proper" way to do this would be to somehow yank var serialization out of the serializer to be able to use it standalone, but this would be a huge undertaking and possible source of bugs due to how complicated the serializer is. Which is doubly problematic given how integral it is. So what I opted for instead is a minimally invasive approach.
WIP: still getting this right and will probably add another test.