bug(flask): Transactions missing body#1034
Conversation
untitaker
left a comment
There was a problem hiding this comment.
please verify manually that the test fails if the fix is not applied
Already did .. fails without the code changes |
|
There is no particular need for the A discussed solution would be to just create an instance of @untitaker is that everything we discussed or would you like to add something? |
|
nah sounds good to me |
Interestingly, sentry has just hit 1.0.0! None of the nominally breaking changes[1] look relevant to our minimal usage: > - Feat: Moved auto_session_tracking experimental flag to a proper > option and removed session_mode, hence enabling release health by > default getsentry/sentry-python#994 > > - Fixed Django transaction name by setting the name to > request.path_info rather than request.path > > - Fix for tracing by getting HTTP headers from span rather than > transaction when possible getsentry/sentry-python#1035 > > - Fix for Flask transactions missing request body in non errored > transactions getsentry/sentry-python#1034 > > - Fix for honoring the X-Forwarded-For header getsentry/sentry-python#1037 > > - Fix for worker that logs data dropping of events with level error > getsentry/sentry-python#1032 [1] https://github.com/getsentry/sentry-python/blob/master/CHANGELOG.md
This PR fixes the bug that transactions were missing data/body because weakref to the request object was garbage collected before the request object made into the event_processor
Ref: https://app.asana.com/0/1142928854421177/1199663160066590