Skip to content

[wip] basic implementation of string truncation with metadata #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
untitaker merged 2 commits into from
Jul 18, 2018
Merged

[wip] basic implementation of string truncation with metadata #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4cb42b
basic implementation of string truncation with metadata
untitaker Jul 16, 2018
5cc8fbb
use databag instead of object term, add depth-truncation
untitaker Jul 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions sentry_sdk/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from .utils import Dsn
from .transport import Transport
from .consts import DEFAULT_OPTIONS, SDK_INFO
from .stripping import strip_event


NO_DSN = object()
Expand Down Expand Up @@ -57,6 +58,10 @@ def _prepare_event(self, event, scope):
if event.get('platform') is None:
event['platform'] = 'python'

if event.get('') is None:
event, event_meta = strip_event(event)
event[""] = event_meta

def capture_event(self, event, scope=None):
"""Captures an event."""
if self._transport is None:
Expand Down
61 changes: 61 additions & 0 deletions sentry_sdk/stripping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
from collections import Mapping, Sequence

from ._compat import text_type

def strip_event(event):
assert "" not in event, "Merging metadata not supported"
old_frames = event.get('stacktrace', {}).get('frames', [])
new_frames = []
frames_meta = {}
meta = {"stacktrace": {"frames": frames_meta}}

for i, frame in old_frames:
frame_meta, new_frame = strip_frame(frame)
new_frames.append(new_frame)
if frame_meta is not None:
frames_meta[str(i)] = frame_meta

return event, meta

def strip_frame(frame):
frame['vars'], meta = strip_databag(frame.get('vars'))
return frame, ({"vars": meta} if meta is not None else None)

def strip_databag(obj, remaining_depth=20):
if remaining_depth <= 0:
return None, {"": {"rem": [["!dep", "x"]]}}
if isinstance(obj, text_type):
return strip_string(obj)
if isinstance(obj, Mapping):
rv = {}
meta = {}
for k, v in obj.items():
rv[k], v_meta = strip_databag(v, remaining_depth - 1)
if v_meta is not None:
meta[k] = v_meta
return rv, meta
if isinstance(obj, Sequence):
rv = []
meta = {}
for i, v in enumerate(obj):
new_v, v_meta = strip_databag(obj, remaining_depth - 1)
rv.append(new_v)
if v_meta is not None:
meta[str(i)] = v_meta
return rv, meta

return obj, None


def strip_string(value, length=512):
if not value:
return value, None
if len(value) > length:
meta = {
"": {
"len": len(value),
"rem": [["!len", "x", length, len(value)]]
}
}
return value[:length - 3] + '...', meta
return value[:length], None