Skip to content

fix: integer arithmetic for timestamps, emit elapsed_since_start_ns as string #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JonasBa merged 1 commit into from
Apr 30, 2026
Merged

fix: integer arithmetic for timestamps, emit elapsed_since_start_ns as string #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions bindings/cpu_profiler.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,7 +566,8 @@ napi_value CreateSample(const napi_env &env, const enum ProfileFormat format,
switch (format) {
case ProfileFormat::kFormatThread: {
napi_value timestamp;
napi_create_int64(env, sample_timestamp_ns, &timestamp);
napi_create_string_utf8(env, std::to_string(sample_timestamp_ns).c_str(),
NAPI_AUTO_LENGTH, &timestamp);
napi_set_named_property(env, js_node, "elapsed_since_start_ns", timestamp);
} break;
case ProfileFormat::kFormatChunk: {
Expand Down Expand Up @@ -641,9 +642,8 @@ static void GetSamples(const napi_env &env, const v8::CpuProfile *profile,
}

uint64_t sample_delta_us = sample_timestamp_us - profile_start_time_us;
uint64_t sample_timestamp_ns = sample_delta_us * 1e3;
uint64_t sample_offset_from_profile_start_ms =
(sample_timestamp_us - profile_start_time_us) * 1e-3;
uint64_t sample_timestamp_ns = sample_delta_us * 1000;
uint64_t sample_offset_from_profile_start_ms = sample_delta_us / 1000;
double seconds_since_start =
(profile_start_timestamp_ms + sample_offset_from_profile_start_ms) *
1e-3;
Expand Down
Loading