Skip to content

Update TypeScript d.t.s (fixes #698)#699

Merged
benvinegar merged 1 commit into
masterfrom
update-ts
Aug 25, 2016
Merged

Update TypeScript d.t.s (fixes #698)#699
benvinegar merged 1 commit into
masterfrom
update-ts

Conversation

@benvinegar

@benvinegar benvinegar commented Aug 24, 2016

Copy link
Copy Markdown
Contributor

cc @macqueen @marcomorain

This change is Reviewable

Comment thread src/raven.js
if (this._breadcrumbs.length > this._globalOptions.maxBreadcrumbs) {
this._breadcrumbs.shift();
}
return this;

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistency with other captureX methods, which are chainable.

@macqueen

Copy link
Copy Markdown

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@benvinegar benvinegar merged commit c39b7e1 into master Aug 25, 2016
@benvinegar benvinegar deleted the update-ts branch August 25, 2016 03:02
denstepa pushed a commit to denstepa/raven-js that referenced this pull request Jan 5, 2017
pull Bot pushed a commit to TheDegenerateDev5150/sentry-javascript that referenced this pull request Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants