Skip to content

Don't assume previous shouldSendCallback exists in RN plugin (fixes #692)#694

Merged
benvinegar merged 2 commits into
masterfrom
fix-rn-plugin
Aug 18, 2016
Merged

Don't assume previous shouldSendCallback exists in RN plugin (fixes #692)#694
benvinegar merged 2 commits into
masterfrom
fix-rn-plugin

Conversation

@benvinegar

@benvinegar benvinegar commented Aug 18, 2016

Copy link
Copy Markdown
Contributor

@benvinegar

Copy link
Copy Markdown
Contributor Author

This change will mean that if FATAL_ERROR_KEY is not in data, transmission will only take place if originalCallback exists and returns true (i.e. user-defined callback). Otherwise this will return undefined and transmission will not take place.

I'm not 100% sure if this is the intended behavior or not. Need someone more familiar to chime off on this (@nevir).

@benvinegar

Copy link
Copy Markdown
Contributor Author

Re-reading the code, I understand now that this code branch is reached if we're dealing with a non-fatal, in which case we should return true (process the exception) unless an original shouldSend handler is present, in which case we use the return value from that.

@nevir

nevir commented Aug 18, 2016

Copy link
Copy Markdown
Contributor

Re-reading the code, I understand now that this code branch is reached if we're dealing with a non-fatal, in which case we should return true (process the exception) unless an original shouldSend handler is present, in which case we use the return value from that.

Yup! This looks correct

@benvinegar benvinegar merged commit bef9fa7 into master Aug 18, 2016
@benvinegar

Copy link
Copy Markdown
Contributor Author

wfm! 3.5.1 going out soon

@benvinegar benvinegar deleted the fix-rn-plugin branch August 18, 2016 21:11
pull Bot pushed a commit to TheDegenerateDev5150/sentry-javascript that referenced this pull request Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants