Repository navigation
fix(server-runtime-injection): Load ESM hook without the build/esm package.json marker - #25562
Draft
andreiborza wants to merge 1 commit into
Draft
andreiborza wants to merge 1 commit into
andreiborza wants to merge 1 commit into
Conversation
…ckage.json marker Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
size-limit report 📦
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5084a8e. Configure here.
| `const d=${JSON.stringify(esmDirUrl)};export async function load(u,c,n){return n(u,u.startsWith(d)?{...c,format:'module'}:c)}`, | ||
| )}`, | ||
| ); | ||
| } |
There was a problem hiding this comment.
Fix PR missing regression test
Medium Severity
This fix PR adds no unit, integration, or E2E test that the diagnostics-channel hook still loads when build/esm/package.json is absent. I flagged this because the review rules require a regression test that fails without the change and passes with it.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 5084a8e. Configure here.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The diagnostics-channel hook now loads as ESM even when
build/esm/package.jsonis missing from a deployment.Why
Vercel runs Node 22 with syntax detection off, so without that file the hook failed to load and channel-based spans were lost.
Closes: #25480